Unverified Commit a2916230 authored by LawiK974's avatar LawiK974 Committed by GitHub
Browse files

Check K3s installed version before download tasks (#297) 



- [Agent : Download artefact only if needed](roles/k3s_agent/tasks/main.yml#L13)
- [Server : Download artefact only if needed](roles/k3s_server/tasks/main.yml#L13)
- [Upgrade : Upgrade node only if needed](roles/k3s_upgrade/tasks/main.yml#L14)

Linked issue #264 k3s_server and k3s_agent tasks are not idempotent

Signed-off-by: default avatarLoïc Dubard <loic97429@gmail.com>
parent 1e266a52

roles/k3s_agent/tasks/main.yml

+33 −18
Original line number Diff line number Diff line 
---

- name: Get k3s installed version

  ansible.builtin.command: k3s --version

  register: k3s_version_output

  changed_when: false

  ignore_errors: true



- name: Set k3s installed version

  when: k3s_version_output.rc == 0

  ansible.builtin.set_fact:

    installed_k3s_version: "{{ k3s_version_output.stdout_lines[0].split(' ')[2] }}"



# If airgapped, all K3s artifacts are already on the node.

# We should be downloading and installing the newer version only if we are in one of the following cases :

#   - we couldn't get k3s installed version in the first task of this role

#   - the installed version of K3s on the nodes is older than the requested version in ansible vars

- name: Download artefact only if needed

  when: k3s_version_output.rc != 0 or installed_k3s_version is version(k3s_version, '<') and airgap_dir is undefined

  block:

    - name: Download K3s install script

  when: airgap_dir is undefined

      ansible.builtin.get_url:

        url: https://get.k3s.io/

        timeout: 120
@@ -11,7 +27,6 @@ 
        mode: 0755



    - name: Download K3s binary

  when: airgap_dir is undefined

      ansible.builtin.command:

        cmd: /usr/local/bin/k3s-install.sh

      environment:

roles/k3s_server/tasks/main.yml

+33 −18
Original line number Diff line number Diff line 
---

- name: Get k3s installed version

  ansible.builtin.command: k3s --version

  register: k3s_version_output

  changed_when: false

  ignore_errors: true



- name: Set k3s installed version

  when: k3s_version_output.rc == 0

  ansible.builtin.set_fact:

    installed_k3s_version: "{{ k3s_version_output.stdout_lines[0].split(' ')[2] }}"



# If airgapped, all K3s artifacts are already on the node.

# We should be downloading and installing the newer version only if we are in one of the following cases :

#   - we couldn't get k3s installed version in the first task of this role

#   - the installed version of K3s on the nodes is older than the requested version in ansible vars

- name: Download artefact only if needed

  when: k3s_version_output.rc != 0 or installed_k3s_version is version(k3s_version, '<') and airgap_dir is undefined

  block:

    - name: Download K3s install script

  when: airgap_dir is undefined

      ansible.builtin.get_url:

        url: https://get.k3s.io/

        timeout: 120
@@ -11,7 +27,6 @@ 
        mode: 0755



    - name: Download K3s binary

  when: airgap_dir is undefined

      ansible.builtin.command:

        cmd: /usr/local/bin/k3s-install.sh

      environment:

roles/k3s_upgrade/tasks/main.yml

+41 −27
Original line number Diff line number Diff line 
---

# with_fileglob doesn't work with remote_src, it tries to find the file on the

# local control-plane instead of the remote host. Shell supports wildcards.

- name: Get k3s installed version

  ansible.builtin.command: k3s --version

  register: k3s_version_output

  changed_when: false



- name: Set k3s installed version

  ansible.builtin.set_fact:

    installed_k3s_version: "{{ k3s_version_output.stdout_lines[0].split(' ')[2] }}"



# We should be downloading and installing the newer version only if we are in the following case :

#   - the installed version of K3s on the nodes is older than the requested version in ansible vars

- name: Update node only if needed

  when: installed_k3s_version is version(k3s_version, '<')

  block:

    - name: Save current K3s service

      ansible.builtin.shell:

        cmd: "cp {{ systemd_dir }}/k3s*.service /tmp/"